feat(backend): implement environment config validation guard#329
Open
armorbreak001 wants to merge 1 commit intoGalactiGuild:mainfrom
Open
feat(backend): implement environment config validation guard#329armorbreak001 wants to merge 1 commit intoGalactiGuild:mainfrom
armorbreak001 wants to merge 1 commit intoGalactiGuild:mainfrom
Conversation
- Add Joi validation schema for all required env vars - Strictly requires: DATABASE_URL, JWT_SECRET, PORT - Conditionally requires REDIS_URL unless QUEUE_DISABLED is set - Validates JWT_SECRET minimum length (16 chars) - Aborts on startup with clear error messages for missing config - Supports storage, mail, and app configuration options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #292
Summary
Added Joi-based environment configuration validation to NestJS
ConfigModule. The app now fails fast at startup with clear error messages if required environment variables are missing.Changes
backend/src/common/config/config.validation.ts— New Joi validation schema:DATABASE_URL,JWT_SECRET(min 16 chars)REDIS_URL(required unlessQUEUE_DISABLED=true)PORT,NODE_ENV,STORAGE_PROVIDER, etc."Missing Configuration: XYZ"backend/src/app.module.ts— UpdatedConfigModule.forRoot():validationSchema: configValidationSchemaabortEarly: false— reports all errors at onceprocess.exit(1)(NestJS default behavior)Prerequisites
Verification